Removed window reference in library to enable usage with web workers#9
Open
ratpik wants to merge 1 commit intovkiryukhin:masterfrom
Open
Removed window reference in library to enable usage with web workers#9ratpik wants to merge 1 commit intovkiryukhin:masterfrom
ratpik wants to merge 1 commit intovkiryukhin:masterfrom
Conversation
Author
|
This closes issue #8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just changing the way the library is globally available by removing
windowreference during initialization. My use case required me to offload some text processing to web workers which is a fairly common thing these days wherein large text is processed asynchronously. By removing the reference towindow, this library can be used with web workers or any other context that breaks when theDOMis referenced.